[5.8] Refactor DELETE query bindings #29165
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to remove
select
bindings fromDELETE
queries to fix cases like this:#22285 fixed this for MySQL, #22298 for SQLite.
#22285 also put
join
bindings first, but that's not necessary. They always come beforewhere
bindings.This PR removes the unnecessary code and moves the fix up to the parent class. This also fixes queries on PostgreSQL and SQL Server.