[5.8] adds Str::containsAll() method

[chrisbbreuer]

Hi everyone,

As discussed here #28688 and #28695 - in order to avoid a breaking change, I abstracted it into a new method called containsAll() and I am using contains() to check whether the value is contained inside the string.

Every now and then I run into a dilemma where I want to check if an array of values is contained within a string.

This adds the functionality to check for all array values inside a string.

Check out the tests to see all the supported scenarios.

I hope you guys find this useful, too 🙂

Chris

[timacdonald]

I'd would think this could explicitly require an array for $needles. Otherwise you would just use Str::contains() for a single item.

i.e. I'm not sure Str::containsAll($names, 'Tim'); makes sense.

[chrisbbreuer]

Thanks for the feedback, Tim. I have asked myself the same question on whether a string should or should not be allowed. I thought it wouldn't "hurt" to keep the functionality and possibly could come in handy at times.

But you're right; logically, Str::contains() would be a more suitable call for that.

Definitely open for a discussion here on whether to keep or to remove it!