Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persist indenting after newlines in replaced content blade templates #28768

Closed
wants to merge 1 commit into from
Closed

Persist indenting after newlines in replaced content blade templates #28768

wants to merge 1 commit into from

Conversation

PrinsFrank
Copy link
Contributor

Fix for issue #28767

Content of included.blade.php:

Line 1
Line 2

Conent of including file:

<html>
     @include('included')
</html>

Results currently in the following HTML:

<html>
     Line 1
Line2 </html>

This fix generates the following HTML:

<html>
     Line 1
     Line2
</html>

@PrinsFrank PrinsFrank changed the title Persist indenting after newlines in replaced content blade templates … Persist indenting after newlines in replaced content blade templates Jun 8, 2019
@laurencei
Copy link
Contributor

IMO seems like alot of changes and code to support a very edge case, where it probably doesnt really matter if the indenting remains anyway?

@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!

If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

@PrinsFrank
Copy link
Contributor Author

It took me a while, but i made it into a package! For anyone stumbling across this pullrequest, the package can be found here:

https://github.com/PrinsFrank/IndentingPersistentBladeCompiler

@vike2000 vike2000 mentioned this pull request May 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PrinsFrank @laurencei @taylorotwell