[5.8] Modified None And React presets to exclude vue-template-compiler #28389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added vue-template-compiler to the list of packages that need to be removed by the 'php artisan preset none' command.
Added vue-template-compiler to the list of packages that need to be removed by the 'php artisan preset react' command.
Closed
|
The same issue, Laravel 5.8.16 |
GrahamCampbell
changed the title
|
Hey @jksdn, I can confirm that the issue hasn't been resolved, but it is not due to Laravel preset system. The behavior is actually caused by Laravel Mix. You can see so in the issue here: laravel-mix/laravel-mix#1877 Kind regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitting a pull request to fix the behavior of React and None frontend scaffolding presets as referenced in issue #.
Have added vue-template-compiler to the list of packages excluded by the two, but have refrained from adding vue-template-compiler into Vue Preset. Will amend it if the maintainers find it valuable for it to be included.