Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Improve output of "assertSessionDoesntHaveErrors" when called with no arguments #28359

Merged
merged 1 commit into from
Apr 29, 2019

Conversation

SjorsO
Copy link
Contributor

@SjorsO SjorsO commented Apr 28, 2019

This PR makes calling assertSessionDoesntHaveErrors() with no arguments forward the call to assertSessionHasNoErrors(). This makes the output more useful when the assertion fails:

Before:
image

After:
image

Related PR: #26039

@SjorsO SjorsO changed the title [5.8] Improve output of "assertSessionDoesntHaveErrors" called with no arguments [5.8] Improve output of "assertSessionDoesntHaveErrors" when called with no arguments Apr 28, 2019
@taylorotwell taylorotwell merged commit 7de9fe0 into laravel:5.8 Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants