[5.8] Fix belongsToMany->wherePivot condition for boolean columns

[edvordo]

Description

Fixes breaking change introduced in #28192, which used weak comparison which in turn caused searching for boolean values belongsToManyRelation->wherePivot('primary', true) (without specifying operator) (See #28251 for more details) in the pivot table to evaluate to true for the conditions $operator == 'in' / $operator == 'not in'.

Switching to typed comparison takes care of this issue.

[staudenmeir]

Maybe we should revert #28192 completely. Even with this fix, ->wherePivot('foo', 'in') is broken.

[JeroenBoesten]

Maybe we should revert #28192 completely. Even with this fix, ->wherePivot('foo', 'in') is broken.

You tested this? Because that should be taken care of by this portion of the where() function in theory.

        [$value, $operator] = $this->prepareValueAndOperator(
            $value, $operator, func_num_args() === 2
        );

[staudenmeir]

@JeroenBoesten wherePivot() works differently:
->wherePivot('foo', 'in') calls ->where('foo', 'in', null, 'and')

This is also the reason why #28192 didn't break ->where('foo', true).

[taylorotwell]

I'm going to revert that entire PR.

[edvordo]

Should at least the test(s) be added so that it screams at people just in case they add it in future again?