[5.8] BUG: Fix quoted environment variable parsing

[mpyw]

For specifying NullBroadcastDriver in Laravel 5.7, we need to explicitly quote value like this:

BROADCAST_DRIVER='"null"'

<env name="BROADCAST_DRIVER" value='"null"' />

In Laravel 5.8, I got this error:

According to @GrahamCampbell's commit #27462:

3. phpdotenv already natively handles quoted variables, so I don't see the need to strip quotes off again. This is only going to be annoying if you'd escaped the quotes in the env file, then laravel strips then anyway.

I think phpdotenv can natively handle quoted values, however, NullBroadcastDriver expects PHP string string(4) "null" on configuration, not string(6) ""null"" or string(6) "'null'".

[mpyw]

Workaround in config/broadcasting.php

<?php

return [

    /* ... */

    'connections' => [

        /* ... */

        'null' => [
            'driver' => 'null',
        ],

        // FIXME: delete me when https://github.com/laravel/framework/pull/27691 merged
        '"null"' => [
            'driver' => 'null',
        ],

    ],

];

[mpyw]

I also propose adding single quotes support:

BROADCAST_DRIVER="'null'"

<env name="BROADCAST_DRIVER" value="'null'" />

---

if (($valueLength = strlen($value)) > 1 && $value[0] === '"' && $value[$valueLength - 1] === '"') {
    return substr($value, 1, -1);
}

↓

if (($valueLength = strlen($value)) > 1 && ($value[0] === '"' && $value[$valueLength - 1] === '"' || $value[0] === "'" && $value[$valueLength - 1] === "'")) {
    return substr($value, 1, -1);
}

[sisve]

Is this something you could add a test for?

[mpyw]

Added test.
(887916b is optional, feel free to pick or drop this)

[taylorotwell]

@GrahamCampbell need your feedback here.

[taylorotwell]

Why did you not keep the same stripping logic we had before? Why did you change to this regular expression? The logic appears a bit different in that it only checks if it begins with quotes and doesn't check if it ends in a quote?

[mpyw]

@taylorotwell \1 means that

[taylorotwell]

I think going forward into future Laravel versions we may want to consider offering an alternative to "null" for these drivers. Even if we still support null, having another name that doesn't have this kinds of problems would be nice.

[Donkfather]

how about 'none' or.. 'nullish' :)

[GrahamCampbell]

This is not broken.

[GrahamCampbell]

You should not have both single and double quotes.

[GrahamCampbell]

@mpyw You should instead have:

BROADCAST_DRIVER="null"

or

BROADCAST_DRIVER='null'

Do not use both quotes.

[mpyw]

• NoneBroadcaster
• NullishBroadcaster
• NilBroadcaster
• MuBroadcaster (like Perl 6 Mu)
• FakeBroadcaster
• DummyBroadcaster