[5.8] Fix wrong class being used when eager loading nullable MorphTo with withDefault() #27455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update tests to account for new behavior
|
So, this only actually takes affect if you have a record with NO polymorphic ID but it has a polymorphic type? |
|
Correct. The use case is described in more detail in the associated issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resubmit of #27411, now without failing tests on master.
Fixes #27369 (and probably #24725)
Currently, MorphTo inherits the
newRelatedInstanceFor()method from BelongsTo, which ignores the passed$parentargument and instantiates a related model based on the generalized relationship instance (without constraints) produced by the query builder . However, in the case of MorphTo relations, the no-constraint relationship instance does not know anything about related classes, and wrongly defaults to the parent model class. This commit simply makes use of the$parentargument to produce a related instance that is appropriate for the parent model instance.Pre-existing tests of MorphTo
withDefault()had to be modified because they relied on the old behavior ofnewRelatedInstanceFor()where it would always return the same predefined instance of the related model. Additionally, a new test was added to ensure that issue #27369 is really fixed.