Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.7] Add a getter for the tag set in TaggedCache #27445

Merged
merged 1 commit into from
Feb 8, 2019
Merged

[5.7] Add a getter for the tag set in TaggedCache #27445

merged 1 commit into from
Feb 8, 2019

Conversation

stancl
Copy link
Contributor

@stancl stancl commented Feb 7, 2019

I'm unable to test a certain part of my package [1] [2] because there is no way to get the tags property of a TaggedCache instance. The property is protected and I didn't want to change that, so I added a getter.

I consider this a minor feature, so as per the docs

Minor features that are fully backwards compatible with the current Laravel release may be sent to the latest stable branch.

I'm sending this PR to the 5.7 branch. I haven't contributed to this repository yet, so just to make sure, will this change be reflected in the next version as well? I can imagine that 5.7 is merged into master when a new version is released, but I'm not sure.

@stancl stancl changed the title Add a getter for the tag set [5.7] Add a getter for the tag set Feb 7, 2019
@stancl stancl changed the title [5.7] Add a getter for the tag set [5.7] Add a getter for the tag set in TaggedCache Feb 7, 2019
@taylorotwell taylorotwell merged commit f4ee68a into laravel:5.7 Feb 8, 2019
@taylorotwell
Copy link
Member

Yes 5.7 is merged into master.

@stancl stancl deleted the stancl-patch-1 branch February 8, 2019 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants