[5.7] Revert "Handle AWS Connection Lost (#25295)" #27418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27053, Refs #25289 & #25295
Queue workers die with userland exception
Any failure in userland to fopen will cause the queue worker to kill itself, because it gets detected by "DetectsLostConnections". This is because this string is too generic in the detection of lost connections when it was intended for database lost connections, but instead it falls for random userland exceptions.
I had first opted to fix the DetectsLostConnection to check exception for DB context, but I don't know enough about internals of Laravel to do that. So I opted instead to revert the commits that added this.
See this comment for more details: #27053 (comment)