[5.7] Update vue preset's vue-stubs for laravel-mix 4 compatibility #27229
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stubs for app.js and ExampleComponent.vue when issuing the
artisan preset vue
command differ from the laravel project's default app.js and ExampleComponent.vue files. Furthermore, the app.js stub is incompatible with laravel-mix 4 because it does not reference.default
.According to the Laravel-Mix 4 upgrade guide https://laravel-mix.com/docs/4.0/upgrade
How to reproduce
Using a fresh install of laravel, issue the
php artisan preset vue
command.I'm thinking this was simply overlooked when upgrading laravel to mix 4, or possibly I'm missing something. Hope this PR helps 👍