-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.7] Bug fix related to extra calls to resolving callbacks (The first way) #27014
[5.7] Bug fix related to extra calls to resolving callbacks (The first way) #27014
Conversation
38cd472
to
a002637
Compare
a002637
to
4e51324
Compare
4e51324
to
30201ef
Compare
da25f0a
to
e2194f0
Compare
a374e3a
to
5f01ad7
Compare
Why a new property ?
|
a685f3e
to
9661ee1
Compare
Note : tests proof that the exact same problem exists for |
3058aa5
to
744ea27
Compare
fda65f3
to
85fe83c
Compare
A lot of tests are added, I know they may look more than needed, but each of them cover a unique case and they all should exists. |
1df63e6
to
0e01521
Compare
0e01521
to
f2b9bf9
Compare
+ bug fix related to multiple calls to "resolving" and "afterResolving" callbacks
f2b9bf9
to
1caaebb
Compare
Add missing tests for the resolving callbacks on the container
The issue is described here :
resolving() events on interfaces are called twice #23699
Also a retry for:
[5.7] Track abstracts being resolved, fire resolving events once #23701
[5.6] Fix double firing of resolving callback #23290