[5.7] Further renaming of scheme from schema #26640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntzm
reviewed
Nov 27, 2018
| * | ||
| * @deprecated In 5.8, this will change to $cachedScheme |
There was a problem hiding this comment.
If it's deprecated, you need something to supersede it
There was a problem hiding this comment.
If the name were private it would not constitute a minor BC change. I don't actually think people are adding macros to UrlGenerator or extending the class in a way where they are directly accessing the cached/in-memory value of the calculated scheme, but to do our due diligence I think we should push the rename to 5.8, just in case.
In the mean time, there is nothing that can simply supersede the original protected property. All it does is track some state, and introducing a secondary (newly named) property would unnecessarily complicate the code for no real value.
|
Thanks |
TBlindaruk
added a commit
to TBlindaruk/laravel-framework
that referenced
this pull request
Dec 2, 2018
…UrlGenerator` - rename `$cachedSchema` property to `$cachedScheme` in `Routing\UrlGenerator`, since in laravel#26640 PR property is deprecated;
TBlindaruk
added a commit
to TBlindaruk/laravel-framework
that referenced
this pull request
Dec 3, 2018
…UrlGenerator` - rename `$cachedSchema` property to `$cachedScheme` in `Routing\UrlGenerator`, since in laravel#26640 PR property is deprecated;
taylorotwell
pushed a commit
to illuminate/routing
that referenced
this pull request
Dec 4, 2018
…UrlGenerator` (#26728) - rename `$cachedSchema` property to `$cachedScheme` in `Routing\UrlGenerator`, since in laravel/framework#26640 PR property is deprecated;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further fix naming of scheme for schema as parameter in
forceScheme().A separate PR for 5.8 will follow that will further rename the protected property
$cachedSchemato$cachedScheme. That change is left out of 5.7 since it is a minor BC break. In 5.8, even though it is a minor BC break, the likelihood of anyone using$cachedSchemais extremely low.No tests here as there is not testable changes (in behavior).