[5.7] Fix #22951 permanently: Using shouldIgnoreMissing on dispatcher mock #26437
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#22951 was "fixed" by adding methods to the dispatcher contract, which is great, but Mockery will still fail if you haven't set up expectations for the methods that get called.
In my particular case, the getCommandHandler method was being called but it hadn't been defined. So I see 2 potential resolutions to this issue:
Since the dispatch and dispatchNow command are mocked, the command handler isn't really used and is fine with being set to null (as best as I can tell) so I went with option 2. I also don't think the con is super bad either with that method.