[5.7] Make expectation closure optional for mock and spy instances #26242
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#26171 introduced the ability to more conveniently add mock and spy instances to the container in a test. These methods require a closure as the second argument.
Passing the closure is perfectly valid, and is the example given in the blog announcement. However, examples of the use of this closure is rare. In fact, AFAIK it's completely undocumented by Laravel and Mockery. Also, requiring the closure is inconvenient where no expectations are desired.
This PR makes the second argument optional.
Before:
After: