[5.7] Always prefer stricter comparison for non-empty strings. #26139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@garygreen I'm a little confused, since it seems you're suggesting this would make case-insensitive comparisons case-sensitive. However, when running var_dump('string' == 'String');
var_dump('string' === 'String');both evaluate to |
|
Thanks for the clarification @browner12 They should always be used by default, UNLESS we have a very good reason not to. |
|
Yeah my bad didn't fully understand changes in PR. Seems reasonable to me |
lucasmichot
deleted the
feature/always-prefer-stricter-non-empty-string-comparison
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always prefer stricter comparison for non-empty strings.