[5.7] Add uuid validation rule to validator

[MASNathan]

Often there is the need to extend the Validator to add a uuid validation rule like this below.

Validator::extend('uuid', function ($attribute, $value, $parameters, $validator) {
    return \Ramsey\Uuid\Uuid::isValid($value);
});

Since Laravel already depends on ramsey/uuid, I think this would be a nice little addition to Laravel's validation ruleset.

Let me know what you think

[X-Coder264]

Since Laravel already depends on ramsey/uuid, I think this would be a nice little addition to Laravel's validation ruleset.

The illuminate/validation component/package does not depend on ramsey/uuid though and that component can be used outside of a full Laravel framework application.

[MASNathan]

The illuminate/validation component/package does not depend on ramsey/uuid though and that component can be used outside of a full Laravel framework application.

@X-Coder264 Didn't think of that, I removed the dependency. Now it uses regex directly

[mfn]

🤔

[MASNathan]

Following ramsey/uuid validation, this is a nil uuid, which is considered valid. We can choose to accept nil uuids or not. What do you think?

[jmarcher]

I think he means that you just hardcoded a case. Make your regex include that case.

Edit: I just saw your regex, it already validate the nil UUID, did you tested this regex or did you just made a copypasta from StackOverflow?

[MASNathan]

Gotcha!

I followed the ramsey/uuid validation workflow. They check it agains 00000000-0000-0000-0000-000000000000 before the regex so I did the same.

[lucasmichot]

As the check is case insensitive it makes sense to use the i option.
Also you can use \d for digits.

return preg_match('/^[\da-f]{8}-[\da-f]{4}-[\da-f]{4}-[\da-f]{4}-[\da-f]{12}$/iD', $value);

[ntzm]

preg_match doesn't return bool, it returns int:

Suggested change

	return preg_match('/^[\da-f]{8}-[\da-f]{4}-[\da-f]{4}-[\da-f]{4}-[\da-f]{12}$/iD', $value);
	return preg_match('/^[\da-f]{8}-[\da-f]{4}-[\da-f]{4}-[\da-f]{4}-[\da-f]{12}$/iD', $value) === 1;

[MASNathan]

Followed validateUrl condition

framework/src/Illuminate/Validation/Concerns/ValidatesAttributes.php

Line 1543 in 8de3736

return preg_match($pattern, $value) > 0;

[taylorotwell]

Does this regex match the regex used by Ramsey UUID?

[svenluijten]

@taylorotwell Functionally it's the same, but the regex this PR uses \d instead of 0-9, and adds the i flag to indicate case-insensitivity instead of being explicit (A-Fa-f). See ramsey/uuid's regex.