[5.7] Revert email lang template changes #25963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurencei
changed the title
|
@laurencei , should we also revert this changes in v5.6? |
TBlindaruk
added a commit
to TBlindaruk/laravel-framework
that referenced
this pull request
Oct 7, 2018
I`m not sure, but probably we also should reverting `email lang template` ([laravel#25734](laravel#25734)) changes in 5.6 version Since in prev 5.6 release we also had: - `Fixed translation escaping ([laravel#25858](laravel#25858), [4c46500](https://github.com/laravel/framework/commit/4c465007bbf51d7f269871cd76b6d99de7df90bb))` for fixed translation escaping The same revert was in 5.7 (laravel#25963)
taylorotwell
pushed a commit
that referenced
this pull request
Oct 7, 2018
* [5.6] Revert email lang template changes. I`m not sure, but probably we also should reverting `email lang template` ([#25734](#25734)) changes in 5.6 version Since in prev 5.6 release we also had: - `Fixed translation escaping ([#25858](#25858), [4c46500](https://github.com/laravel/framework/commit/4c465007bbf51d7f269871cd76b6d99de7df90bb))` for fixed translation escaping The same revert was in 5.7 (#25963) * [5.6] Revert email lang template changes. - add `comma` after last value in array.
taylorotwell
pushed a commit
to illuminate/notifications
that referenced
this pull request
Oct 7, 2018
* [5.6] Revert email lang template changes. I`m not sure, but probably we also should reverting `email lang template` ([#25734](laravel/framework#25734)) changes in 5.6 version Since in prev 5.6 release we also had: - `Fixed translation escaping ([#25858](laravel/framework#25858), [4c46500](https://github.com/laravel/framework/commit/4c465007bbf51d7f269871cd76b6d99de7df90bb))` for fixed translation escaping The same revert was in 5.7 (laravel/framework#25963) * [5.6] Revert email lang template changes. - add `comma` after last value in array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts my original PR #25723 - because all the
langchanges have been reverted, so we should revert this as well.