[5.6] Fix mailables always being queued for later if using Queueable trait #25378
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a Mailable uses the
\Illuminate\Bus\Queueable
trait, which is the default when usingmake:mail
, it will always end up calling\Illuminate\Mail\Mailable::later
because it is only checking if thedelay
property exists and not whether it is actually set.This is a problem when using a 3rd part queue driver like https://github.com/shiftonelabs/laravel-sqs-fifo-queue which doesn't allow things to be queued for later since sqs fifo queues do not support it.
This fixes that problem by checking whether
delay
is actually set.