[5.6] Fix ConnectionInterface methods #25092
Conversation
Declaration of Illuminate\Database\Connection class methods must be compatible with Illuminate\Database\ConnectionInterface
|
Probably should just target 5.7 that is due out soon, since your technically changing an interface file... |
This reverts commit 7a5b58b.
GrahamCampbell
changed the title
|
This fix was already made to 5.7 quite a while ago. I've reverted this on 5.6 because it is a major breaking change. It remains on 5.7+. |
|
I came across with an issue on 5.6 while using decorated Connection class where I am overriding a method, and since I noticed my implementation does comply with the interface it however fails to inherit the connection class. The parameter was added to version 5.6 according to this PR 8afc151 🙄 |
|
Sorry, my bad, didn’t really check when it was added as I was on mobile. Even though it’s been added and still do exist in 5.6 with a method that contracts to the interface, shouldn’t they comply? |
No as that it a major breaking change to a contract. |
Declaration of Illuminate\Database\Connection class methods must be compatible with Illuminate\Database\ConnectionInterface
Does not require any change in the tests.
Doesn't break any existing feature.