[5.6] Fix isDirty(null) and wasChanged(null) #23929
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HasAttributes::isDirty()
is defined like this:Calling
isDirty()
on a modified model returnstrue
. But explicitly using the default value returnsfalse
:So something like
$model->isDirty($if ? ['foo'] : null)
doesn't work.The same applies to
HasAttributes::wasChanged()
.Fixes #23924.