[5.5] Where clauses should use original attribute values #23031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With current implementation, it is impossible to update any of the foreign or related keys in Pivot instance, without executing raw SQL queries, as the generated query is using current attribute values instead of the original values. This commit will fix this issue.
This commit fixes failed test case, where a Pivot is directly instantiated using Mockery and delete is attempted.
|
I don't know how to fix the failed test. I tried, but failed. :-( Feel free to close this PR. |
|
You had a typo in your code. I fixed it. |
|
Silly copy-paste error in hastiness at dead of night. :-) Thanks a lot @taylorotwell 👍 |
|
Could you please provide a sample code of what becomes possible by this commit? |
GrahamCampbell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With current implementation, it is impossible to update any of the foreign or related keys in Pivot instance, without executing raw SQL queries, as the generated query is using current attribute values instead of the original values. This PR will fix this issue.