Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing functions in Dispatcher contract (#22951) #22953

Closed

Conversation

Naouak
Copy link
Contributor

@Naouak Naouak commented Jan 29, 2018

No description provided.

@taylorotwell
Copy link
Member

No plans to add these right now.

@Naouak
Copy link
Contributor Author

Naouak commented Jan 29, 2018

It's a bugfix, see #22951 not a new feature.

@laurencei
Copy link
Contributor

@Naouak - the problem is you cannot change a contract on a point release, even if it is technically a bug fix.

Your best bet is to target this to the 5.6 branch.

Also - you posted this PR without providing any description, examples or tests to show Taylor what this PR is for. You should take the time to write a detailed description of the problem, how this fixes it etc, and that way Taylor can judge it for inclusion.

@Naouak
Copy link
Contributor Author

Naouak commented Jan 29, 2018

So basically, the LTS version is doomed to have broken tests and broken dispatchers because the contract is no good. You are telling developers to either not be able to test everything or go with a more heavy maintenance. This is not good. An incomplete contract is a serious bug that should be fixed ASAP as it makes the contract system useless.

I did provide a huge description of the problem, the consequences and how to reproduce it in the issue mentioned in the title and the commit message. I'm sorry if this was not clear enough.

@laurencei
Copy link
Contributor

laurencei commented Jan 29, 2018

@Naouak - but it cant be fixed - because it might be an unexpected breaking change to anyone doing a normal update. So the only solution is to put it into 5.6.

You should be able to extend the class, add your functions, then mock it for your tests using Partial Mocks - so there is a way around it for 5.5, although it is not ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants