Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] Revert #22649 #22815

Merged
merged 1 commit into from
Jan 16, 2018
Merged

[5.5] Revert #22649 #22815

merged 1 commit into from
Jan 16, 2018

Conversation

timoschwarzer
Copy link
Contributor

That commit caused unit tests using the actingAs helper to fail

That commit caused unit tests using the actingAs helper to fail
@timoschwarzer timoschwarzer changed the title Revert #22649 [5.5] Revert #22649 Jan 16, 2018
@sisve
Copy link
Contributor

sisve commented Jan 16, 2018

It would be nice to have a tests for actingAs so it doesn't fail again.

@crynobone
Copy link
Member

I would actually opt for fixing actingAs() instead of doing this.

@taylorotwell
Copy link
Member

How exactly did it cause it to fail. We need more information?

@taylorotwell taylorotwell merged commit a948d90 into laravel:5.5 Jan 16, 2018
@timoschwarzer
Copy link
Contributor Author

@taylorotwell the actingAs helper called setRequest which has set the user to null again.

@vlakoff
Copy link
Contributor

vlakoff commented Jan 17, 2018

Refs #22817 that has subsequently added tests for this.

@crynobone
Copy link
Member

Should note the added tests doesn't break with and without the "broken" changes. I don't have enough information to replicate the issues.

In the other thread it does mention that request is being rebind before call() is being made but auth service provider already cover these scenarios.

If anyone want to properly prevent such issues, need to further improve the test. Otherwise same thing can happen again, since tests is green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants