Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] Add support for new author fields in slack message attachment #22610

Merged
merged 2 commits into from
Jan 2, 2018
Merged

[5.5] Add support for new author fields in slack message attachment #22610

merged 2 commits into from
Jan 2, 2018

Conversation

wanghanlin
Copy link
Contributor

Add support for new author fields in slack message attachment mentioned in #22588

new fields can be found in slack docs: https://api.slack.com/docs/message-attachments

* Set the author.
*
* @param string $name
* @param string $link
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

string|null

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GrahamCampbell Updated, I also updated another place missing null in line 120, let me know if you want me separate that change to a new PR.

@taylorotwell taylorotwell merged commit 2093e7e into laravel:5.5 Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants