Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] flush listeners of custom eloquent events #21688

Merged
merged 2 commits into from
Oct 16, 2017

Conversation

themsaid
Copy link
Member

Having this in your model:

class User extends Model
{
    protected $dispatchesEvents = ['created' => UserCreated::class];
}

Currently if you do this in your tests:

public function testFlushEventListeners()
    {
        User::flushEventListeners();
        
        $user = factory(User::class)->create();
    }

The listeners of the UserCreated are still going to be fired, this PR fixes that.

@taylorotwell taylorotwell merged commit 039b565 into laravel:5.5 Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants