[5.5] Bail when array is provided as key in Session::flash #21576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey. It will be nice if next time you spot a bug you create an issue first so that people can test it out and confirm whether it is a bug or not. It is fine for this one 👍 |
|
Of course, makes sense. |
|
Changed it to just use a string type hint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When someone (accidentally) provides an array as key using
Session::flash(), the app breaks for users visiting the page until they have cleared their browser cache. It can be hard to identify the problem when there's no exception thrown.This is my first PR and I don't know if it qualifies, but I thought I'd give it a shot. Feedback is much appreciated.