Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] Enhance Mailable queueing #21569

Closed
wants to merge 2 commits into from
Closed

[5.5] Enhance Mailable queueing #21569

wants to merge 2 commits into from

Conversation

aleksandrlat
Copy link

It is impossible to enhance or change queue job in Mailable now.

For example it would be nice to add failed method to Job to handle job failures. But it is impossible now.

With job factory method we can use any custom Job for Mailables. It will be possible to add failed method.

@taylorotwell
Copy link
Member

I would rather just support failed in Mailables and Notifications, etc.

@themsaid is it not possible already?

@aleksandrlat
Copy link
Author

failed is one of use cases. There maybe other probably.
Having failed in Mailables and Notifications would be nice.

@taylorotwell
Copy link
Member

I would rather do that than hack this in. @themsaid

@themsaid
Copy link
Member

themsaid commented Oct 8, 2017

@taylorotwell Here's a PR to support failed() in mailable and notifictaions: #21585

@aleksandrlat what else do you think should be supported?

@aleksandrlat
Copy link
Author

aleksandrlat commented Oct 9, 2017

I just thought about other potential tasks. I don't have something concrete in mind.

@themsaid thank you for failed method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants