[5.5] Add more uncountable nouns #21476
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, but your list is wrong, there are quite a few words that are indeed countable. |
GrahamCampbell
requested changes
Oct 1, 2017
| 'data', | ||
| 'deer', | ||
| 'distribution', |
There was a problem hiding this comment.
This is definitely countable.
jmarcher
reviewed
Oct 1, 2017
| @@ -12,28 +12,45 @@ class Pluralizer | |||
| * @var array | |||
| */ | |||
| public static $uncountable = [ | |||
| 'access', | |||
| 'accommodation', | |||
| 'advice', | |||
| @@ -42,14 +59,20 @@ class Pluralizer | |||
| 'plankton', | |||
| 'pokemon', | |||
| 'police', | |||
| 'quality', | |||
| @@ -42,14 +59,20 @@ class Pluralizer | |||
| 'plankton', | |||
| 'pokemon', | |||
| 'police', | |||
| 'quality', | |||
| 'quantity', | |||
|
I shouldn't make PR's late at night 😅 Thanks, @jmarcher and @GrahamCampbell. I removed those words. |
|
@manniL This is a breaking change and should go to the |
|
@manniL See discussion from #21324 (comment). |
|
Please send to master. There have been enough potentially breaking additions for people to deal with. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.