Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] pad function added to collections #21342

Merged
merged 2 commits into from
Sep 23, 2017
Merged

[5.5] pad function added to collections #21342

merged 2 commits into from
Sep 23, 2017

Conversation

Dylan-DPC-zz
Copy link

Pad function added to collections as per request laravel/ideas#806

@Dylan-DPC-zz Dylan-DPC-zz changed the title pad function added to collections [5.5] pad function added to collections Sep 22, 2017
@sisve
Copy link
Contributor

sisve commented Sep 23, 2017

Does it ... pad left? right? top? bottom? center? There's lots of docs missing on this one. Should $value be nullable? How does this affect Collections that use keys?

@Dylan-DPC-zz
Copy link
Author

Didn't want to throw everything in the docblocks. But it works same as array_pad.

@taylorotwell taylorotwell merged commit 9638e36 into laravel:5.5 Sep 23, 2017
@Dylan-DPC-zz Dylan-DPC-zz deleted the pad_fn branch September 23, 2017 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants