[5.5] Ignore select bindings while building update query #21173
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test with this PR shows an example of a sub select query using the default
withCount
model property, but this basically affects every sub select query.When building the update query, we use
where
andjoin
bindings but we don't use theselect
bindings, so any leftovers in thisselect
binding will be used by the final query even though the final query doesn't need it, which will cause incorrect order of bindings.This PR fixes the following issue: #20640