Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.5] Completed BelongsToMany Parent Key Change #21044

Merged
merged 2 commits into from
Sep 7, 2017
Merged

[5.5] Completed BelongsToMany Parent Key Change #21044

merged 2 commits into from
Sep 7, 2017

Commits on Sep 6, 2017

  1. Resolve Eager Loading Problem with BelongsToMany 

    This resolves the problem of the relation not making use of the parentKey for the parent Models.
    @Upperfoot
    Upperfoot authored Sep 6, 2017
    Configuration menu
    Copy the full SHA
    b52c53e View commit details
    Browse the repository at this point in the history

  2. Completed BelongsToMany Parent Key Change 

    This resolves the issue where BelongsToMany.php makes use of parentKey, but this concern (InteractsWithPivotTable) does not make use of parentKey at all, and instead still uses the old $this->parent->getKey() rather than $this->parent->{$this->parentKey}

This references this change e4f8884 which has been superceded by 00c2c5a

There also requires a change in BelongsToMany to resolve Eager Loading.
    @Upperfoot
    Upperfoot authored Sep 6, 2017
    Configuration menu
    Copy the full SHA
    0dbf487 View commit details
    Browse the repository at this point in the history