[5.5] Updated Console/Kernel autoloading of commands to ignore abstract classes #20931
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new Laravel 5.5 auto loading of console commands is great.
Unfortunately it didn't work in my app, as I use an abstract class that extends
Illuminate\Console\Command
, so theis_subclass_of($command, Command::class)
was resolving that abstract class causing aIlluminate\Contracts\Container\BindingResolutionException
exception.This PR changes the conditional to use
ReflectionClass
and theisAbstract
andisSubclassOf
methods, fixing this issue.PS. My abstract console class is extended by custom migration classes that are necessary for our multi-tenant / multi-database migrations, while the base migrator commands act on our primary database.