Fixes in Auth/Console #20707
Merged
Fixes in Auth/Console #20707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passwords/reset.stub was handling a success status message stored in session, but there isn't a flow that redirects to that view with said message since the user is authenticated and redirected into the application itself when the password is successfully changed. This commit moves the status message from the passwords/reset.stub to the home.stub so it's clear to the user that his password was changed once he is logged in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The passwords/reset stub was handling a success status message stored in session, but there isn't a flow that redirects to that view with said message since the user is authenticated and redirected into the application itself when the password is successfully changed. This commit moves the status message from the passwords/reset.stub to the home.stub so it's clear to the user that his password was changed once he is logged in.
The spacing was inconsistent between views that were using the same element. I just added some spacing to fix it.