[5.4] Make job fail only if it not failed already

[netpok]

This will prevent calling statsJob on an already failed and therefore deleted job, which would create another exception.

In case of beanstalk queue driver this will make queue worker to correctly report MaxAttemptsExceededException instead of Pheanstalk ServerException.

[taylorotwell]

Eh, how do you recreate this situation?

[netpok]

I can only speak in the case of beanstalk queue driver:

Steps to recreate:

• Use beanstalk queue driver
• Make a job that will timeout
• After reaching the limit it will produce the mentioned exception on the next attempt

Reason:
The markJobAsFailedIfAlreadyExceedsMaxAttempts will fail the job and delete from the queue and then throw a MaxAttemptsExceededException. This exception will be catched and processed with the handleJobException, which will call markJobAsFailedIfWillExceedMaxAttempts and that function will try to stat the already deleted job by calling the $job->attempts() method.

Stack trace: https://pastebin.com/L3wG1kX4