[5.4] Fix make:policy Command #20645
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decadence
reviewed
Aug 20, 2017
| @@ -82,6 +82,11 @@ protected function replaceModel($stub, $model) | |||
| $stub = str_replace('NamespacedDummyModel', $this->laravel->getNamespace().$model, $stub); | |||
| } | |||
|
|
|||
| $namspaceModel = $this->laravel->getNamespace().$model; | |||
|
This PR has typos. |
|
@taylorotwell , I'm wondering why are you closing PR instantly if issues are found during review process. This completely disables dialog possibility on PR code or even fixing attempt as separate commit on same PR. Any practical reasons behind this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When create the User policy
php artisan make:policy UserPolicy -m Userwill duplicate the
App\Userclass imports