Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.4] Support amount 0 in Arr::random() #20439

Merged
merged 9 commits into from
Aug 6, 2017
Merged

[5.4] Support amount 0 in Arr::random() #20439

merged 9 commits into from
Aug 6, 2017

Commits on Aug 5, 2017

  1. Shorten name of variable

    @vlakoff
    vlakoff committed Aug 5, 2017
    Configuration menu
    Copy the full SHA
    8ad4b82 View commit details
    Browse the repository at this point in the history

  2. Move test to main method 

    I overlooked it, so I guess it's better to consolidate in one method.
    @vlakoff
    vlakoff committed Aug 5, 2017
    Configuration menu
    Copy the full SHA
    bad0d7a View commit details
    Browse the repository at this point in the history

  3. Rewrite to be more readable and safer with "0" value

    @vlakoff
    vlakoff committed Aug 5, 2017
    Configuration menu
    Copy the full SHA
    b78bb4e View commit details
    Browse the repository at this point in the history

  4. Support amount 0 in Arr::random() 

    For consistency with Collection::random()
    @vlakoff
    vlakoff committed Aug 5, 2017
    Configuration menu
    Copy the full SHA
    f0f734b View commit details
    Browse the repository at this point in the history

  5. Remove code for handling amount 0 in Collection::random() 

    Now redundant because Arr::random() supports it.
DRY principle, and the case is covered by tests.
    @vlakoff
    vlakoff committed Aug 5, 2017
    Configuration menu
    Copy the full SHA
    edbc5d0 View commit details
    Browse the repository at this point in the history

  6. Support amount '0' as a string in Arr and Collection random() 

    For consistency with other numbers, as they are accepted as strings.
    @vlakoff
    vlakoff committed Aug 5, 2017
    Configuration menu
    Copy the full SHA
    b93b7ae View commit details
    Browse the repository at this point in the history

  7. Add test cases when requesting too many items in random methods

    @vlakoff
    vlakoff committed Aug 5, 2017
    Configuration menu
    Copy the full SHA
    9dec807 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2017

  1. Remove redundant validation code

    @vlakoff
    vlakoff committed Aug 6, 2017
    Configuration menu
    Copy the full SHA
    e751518 View commit details
    Browse the repository at this point in the history

  2. Update Arr.php

    @taylorotwell
    taylorotwell authored Aug 6, 2017
    Configuration menu
    Copy the full SHA
    46699d5 View commit details
    Browse the repository at this point in the history