[5.4] Use getClientOriginalExtension() when available #20400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't they just have to manually change the extension now? That value is entirely spoofable? |
|
But that it what the file will be saved as. So they can upload a php file as It is combined with the MIME test as well. |
|
Kinda boggles my mind people are saving user uploaded files with the "php" extension in their apps but OK. |
|
@taylorotwell - they are not be meaning to. If they do some save file after an image validation - then they are expecting |
This was referenced Aug 5, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems
getClientOriginalExtension()is more reliable for an uploaded file during my testing. So we should use that when available. It uses the actual file extension and does not try to guess it.