[5.5] Don't try to drop Views when executing MySqlBuilder::dropAllTables() #20239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@freekmurze may have some feedback here. |
|
In the laravel-migrate-fresh package we used a query to fetch the names of all real tables. |
tillkruss
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current MySqlBuilder::dropAllTables() function used by migrate:fresh uses "SHOW TABLES" and issues a "DROP TABLE" Query for all returned Values. This causes MySQL errors once a view exists in the database used for Laravel, as Views can only be droped by "DROP VIEW".
Not sure if using Views is a covered Use-Case for Laravel, but figured i might aswell submit a fix for it.
MySQL Documentation at https://dev.mysql.com/doc/refman/5.7/en/show-tables.html on SHOW TABLES:
"This statement also lists any views in the database. The optional FULL modifier causes SHOW TABLES to display a second output column with values of BASE TABLE for a table and VIEW for a view. "