-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.5] Make pivot model instantiable #20179
Merged
taylorotwell
merged 3 commits into
laravel:master
from
BertvanHoekelen:bugfix/17770-pivot-model-can-be-instantiated
Jul 20, 2017
Merged
[5.5] Make pivot model instantiable #20179
taylorotwell
merged 3 commits into
laravel:master
from
BertvanHoekelen:bugfix/17770-pivot-model-can-be-instantiated
Jul 20, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paste an entire example of how to recreate this in Laravel. |
See http://github.com/bertvanhoekelen/pivot-model-example. This test will throw the following exception:
City.php <?php
namespace App;
use Illuminate\Database\Eloquent\Model;
class City extends Model
{
protected $guarded = [];
public function products()
{
return $this->belongsToMany(Product::class)->withPivot(['id'])->using(CityProduct::class);
}
} Product.php <?php
namespace App;
use Illuminate\Database\Eloquent\Model;
class Product extends Model
{
protected $guarded = [];
public function cities()
{
return $this->belongsToMany(City::class)->withPivot(['id'])->using(CityProduct::class);
}
} CityProduct.php <?php
namespace App;
use Illuminate\Database\Eloquent\Relations\Pivot;
class CityProduct extends Pivot
{
public function city()
{
return $this->belongsTo(City::class);
}
public function product()
{
return $this->belongsTo(Product::class);
}
public function order()
{
return $this->hasOne(Order::class);
}
} Order.php <?php
namespace App;
use Illuminate\Database\Eloquent\Model;
class Order extends Model
{
protected $guarded = [];
public function cityProduct()
{
return $this->belongsTo(CityProduct::class);
}
} PivotModelIsNotInstantiableTest.php <?php
namespace Tests\Unit;
use App\City;
use App\Order;
use App\Product;
use Tests\TestCase;
use Illuminate\Foundation\Testing\DatabaseMigrations;
class PivotModelIsNotInstantiableTest extends TestCase
{
use DatabaseMigrations;
/** @test */
public function pivot_model_is_not_instantiable()
{
$city = City::create(['name' => 'Amsterdam']);
$product = Product::create(['name' => 'Burger']);
$city->products()->attach($product->id);
$cityProduct = $city->products()->first()->pivot;
$order = Order::create(['city_product_id' => $cityProduct->id]);
$this->assertEquals($cityProduct->id, $order->cityProduct->id);
}
} |
Thanks |
This way to make relationship is working? or there is other way? |
I'm facing this problem right now. I love its solved, but I'm using 5.4 dammit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was facing the same problems as described in #17770.
When I added a
hasOne
relation to the pivot model, it was not able to construct the pivot instance on the inverse side of the relation. This PR makes the pivot model behave more like a regular model so it can be instantiated without the need of the pivot attributes.