[5.5] Add get method in the Relation class #20052
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Reopened)
This PR is a micro optimisation on one side, but on the other side I think it is good to be explicit here since the
BelongsToMany
class is actually "overriding" the (non-declared) get method.For example I thought I could change this:
To this:
Since
get()
was just a call to a "magic method"But this actually caused 2 tests to fail because
get
is (re)declared inBelongsToMany
.