Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] Add 404 request method and url when using withoutExceptionHandling #20000

Merged
merged 1 commit into from
Jul 11, 2017
Merged

[5.5] Add 404 request method and url when using withoutExceptionHandling #20000

merged 1 commit into from
Jul 11, 2017

Conversation

BrandonSurowiec
Copy link
Contributor

Whenever a NotFoundHTTPException is thrown, it is helpful to see the request method and url. Helps to debug what route to look at instead of having to first look it up in the test file. I've been using this in my own tests and I love it.

Final result:

1) Tests\Feature\Backstage\PublishConcertTest::a_promoter_can_publish_their_own_concert
Symfony\Component\HttpKernel\Exception\NotFoundHttpException: POST http://ticketbeast.app/backstage/published-concerts

Whenever a NotFoundHTTPException is thrown, it is helpful to see the request method and url. Helps to debug what route to look at instead of having to first look it up in the test file. I've been using this in my own tests and I love it.

Final result:

```
1) Tests\Feature\Backstage\PublishConcertTest::a_promoter_can_publish_their_own_concert
Symfony\Component\HttpKernel\Exception\NotFoundHttpException: POST http://ticketbeast.app/backstage/published-concerts
```
@taylorotwell taylorotwell merged commit d210c84 into laravel:master Jul 11, 2017
@BrandonSurowiec BrandonSurowiec deleted the patch-1 branch July 11, 2017 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants