[5.4] Add endOfMonth() to Console\Scheduling\ManagesFrequencies.

[coderabbi]

The title says it all. The last day of the month is a common use case, this provides a convenience method for that use case akin to weekends() being a convenience method for its use case. Implementation is consistent with the similar combination of between() and inTimeInterval().

[decadence]

Do you test it? day method sets day for the current Carbon not returns day number. daysInMonth doesn't even exist.
You need return $now->day == $now->daysInMonth;
See briannesbitt/Carbon#973

[coderabbi]

Argh! You're right!! That's what I get for racing to do it over breakfast... 😊 Correction incoming.

[coderabbi]

Corrected.

I do that every single time with Carbon. Gah. Hats the method/property name overlap, we do.

[lucasmichot]

We are comparing 2 integers, I believe we can strictly compare with ===

[taylorotwell]

One thing I'm not sure about with this one is wouldn't it be expected to run a "end of month" report at midnight on the first day of the next month? Is that what this does? If not, and you are running an end of month report, it seems like you would miss the entire last day of the month.

[lucasmichot]

Maybe change to '23:59' as a default?

[taylorotwell]

If you want to month a monthly report it seems to me you would just run monthly() on the scheduler, which will run at midnight of first day of month.

[decadence]

Maybe someone has task for current month values. So it fails on the next month.

[coderabbi]

Indeed, it may be a method without a justifiable use case. I wasn't thinking so much reports for this one as notifications... end of the month is a common deadline. Of course then you'd want x days prior... Hmmm.

[coderabbi]

@taylorotwell While I have your attention, what are your thoughts about an EOM (or similar) constant (well, not a constant because we're in a trait, so it'd have to just be a key word) that could be used in place of specific days in other methods which accept a day of the month as an argument (i.e. monthlyOn('eom', '23:59')?

[taylorotwell]

I'll just let monthly suffice for now.

[coderabbi]

Gonna make one more pitch... ;-)

Carbon offers:

• firstOfMonth()
• lastOfMonth()
• nthOfMonth()
• firstOfQuarter()
• lastOfQuarter()
• nthOfQuarter()
• firstOfYear()
• lastOfYear()
• nthOfYear()

So it would appear that there was sufficient use case for Carbon. ;-)

Of course, the argument could be made to... just use Carbon.

I'm thinking that exchanging the when() w/ a closure & predictable logic for lastOfQuarter(), for instance, is a win for the user, extending a simple, descriptive, fluent sytax to more use cases.

[lucasmichot]

Yitzchok, with #19771 in 5.5, Carbon will be Macrobale 🤘