Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.4] Remove unnecessary role="form" from auth templates #19792

Merged
merged 1 commit into from
Jun 27, 2017
Merged

[5.4] Remove unnecessary role="form" from auth templates #19792

merged 1 commit into from
Jun 27, 2017

Conversation

4refael
Copy link
Contributor

@4refael 4refael commented Jun 27, 2017 •
edited
Loading

The role="form" attribute for form elements is unnecessary.

Source:

In the majority of cases setting an ARIA role and/or aria-* attribute that matches the default implicit ARIA semantics is unnecessary and not recommended as these properties are already set by the browser.

@tillkruss tillkruss changed the title Remove unnecessary role="form" from auth templates [5.4] Remove unnecessary role="form" from auth templates Jun 27, 2017
@taylorotwell taylorotwell merged commit 9ca81af into laravel:5.4 Jun 27, 2017
@4refael 4refael deleted the role_form branch November 21, 2017 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@4refael @taylorotwell