Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] Run after-callbacks even if a callback event failed #19573

Merged
merged 2 commits into from
Jun 12, 2017
Merged

[5.5] Run after-callbacks even if a callback event failed #19573

merged 2 commits into from
Jun 12, 2017

Conversation

themsaid
Copy link
Member

Currently if you use exec(), or command() an after-callback will run even if the command itself threw an exception since the command runs in a sub-process.

However when you use a callback event, any exception in the callback will prevent the script from continuing and thus cause the after-callbacks to never fire.

This PR fixes this issue by ensuring the after-callbacks are called even if the callback event failed.

@taylorotwell taylorotwell merged commit 0b9b8cd into laravel:master Jun 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants