[5.5] Run after-callbacks even if a callback event failed #19573
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you use
exec()
, orcommand()
an after-callback will run even if the command itself threw an exception since the command runs in a sub-process.However when you use a callback event, any exception in the callback will prevent the script from continuing and thus cause the after-callbacks to never fire.
This PR fixes this issue by ensuring the after-callbacks are called even if the callback event failed.