Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.4] Fix Timeoutless Job #19266

Merged
merged 1 commit into from
May 20, 2017
Merged

Conversation

dbpolito
Copy link
Contributor

@dbpolito dbpolito commented May 18, 2017

If you set a job timeout to 0, it's being simply ignored, my PR fixes it.

class MyJob extends Job {
    public $timeout = 0;

    [...]
}

I haven't added any tests because there is no test at all for the timeout functionality.

@taylorotwell taylorotwell merged commit 650f74c into laravel:5.4 May 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants