[5.4] Adds isRouteName method #19202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntzm
reviewed
May 15, 2017
src/Illuminate/Http/Request.php
Outdated
| return true; | ||
| } | ||
|
|
||
| return false; |
There was a problem hiding this comment.
This can be reduced to just return $this->route()->getName() === $name;
There was a problem hiding this comment.
Even better: $this->route()->currentRouteNamed($name)
P.S. I'm wrong, this method only for Route facade.
There was a problem hiding this comment.
Maybe it's worth to add method isName for Route instances.
Merged
|
Can this be used as |
|
Yes, but original method was renamed to |
|
I tried isRouteName but it looks like it got switched :) still super handy :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
isRouteNamemethod to the Request.For use cases such as
Request::isRouteName(‘foo.bar’)this allows easier route changes in the future.