Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] Queue worker will pass connection + queue name to Looping event #19081

Merged
merged 1 commit into from
May 8, 2017
Merged

[5.5] Queue worker will pass connection + queue name to Looping event #19081

merged 1 commit into from
May 8, 2017

Conversation

stierler
Copy link
Contributor

@stierler stierler commented May 6, 2017

Re-creating PR to master instead of 5.4, as requested by @taylorotwell
(I modified the previous - #18975 but couldn't reopen)

@tillkruss tillkruss changed the title Queue worker will pass connection + queue name to Looping event [5.5] Queue worker will pass connection + queue name to Looping event May 6, 2017
@laurencei
Copy link
Contributor

What about the idea I mentioned on the other thread - modify WorkerOptions to have a copy/knowledge of connectionName and queue - then just pass WorkerOptions into the looping event?

This gives more options to people who want to hook into the loop event, so they can know sleep, timeout etc - rather than just two static variables.

And it makes sense for WorkerOptions to know the connectionName and queue anyway.

@taylorotwell taylorotwell merged commit 3f01a66 into laravel:master May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants