Replacing hardcoded protocol in mix helper #18943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not solve "the whole problem" however currently the mix helper hardcodes the port and protocol. When using SSL on your development environment browsers refuse to load the assets served by mix when using HMR over http This change makes sure it uses the correct protocol. Although it doesn't solve the issue of users not having SSL on "localhost"
| return new HtmlString("http://localhost:8080{$path}"); | ||
| $hotProtocol = request()->secure() ? 'https' : 'http'; | ||
|
|
||
| return new HtmlString("{$hotProtocol}://localhost:8080{$path}"); |
There was a problem hiding this comment.
You can simply use a protocol-relative URL:
return new HtmlString("//localhost:8080{$path}");There was a problem hiding this comment.
Ha sure, that also works, guess I definitely over engineered that :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not solve "the whole problem" however currently the mix helper hardcodes the port and protocol.
When using SSL on your development environment browsers refuse to load the assets served by mix when using HMR over http
This change makes sure it uses the correct protocol.
Although it doesn't solve the issue of users not having SSL on "localhost"