[5.4] Asterisk don't get replaced for custom rules on array validation

[rakesh-beedasy]

Illuminate\Validation\Validator@validateAttribute fails to replace '*' on array attributes since Illuminate\Validation\Validator@dependsOnOtherFields returns false for any custom extension.

When registering a custom validator one should be able to merge rules to Illuminate\Validation\Validator@$dependentRules

E.g.
Illuminate\Support\Facades\Validator::extendImplicit('required_if_in', App\ValidatorsRequiredIfIn::class);
Illuminate\Support\Facades\Validator::extendDependent('required_if_in', App\ValidatorsRequiredIfIn::class);
works with rules like
$rules = ['items.*.field' => 'required_if_in:items.*.otherfield,value1,value2']

[GrahamCampbell]

Thanks. Please add tests. :)

[taylorotwell]

@themsaid can you review this? is this really needed?

[themsaid]

On it

[rakesh-beedasy]

I tried to extend Illuminate\Support\Facades\Validator with a custom implicit validation rule where a field would depend on another field's value. While it works fine when using single fields when defining my rules, it fails when defining arrays for validation.

Since I can't modify Illuminate\Validation\Validator::$dependentRules property, the '*' in the other field never gets replaced by the corresponding index for each array item.

$rules = ['items.*.field' => 'required_if_in:items.*.otherfield,value1,value2']

For each items '*' for 'field' gets correctly replaced by indexes 0,1,2 and so on but not for 'otherfield'.

E.g. if I have an array of 2 items, for each item that gets passed on to my custom validation rule function I get

$attribute as item.0.field, but $parameters[0] as item.*.otherfield  
$attribute as item.1.field, but $parameters[0] as item.*.otherfield 

when I'm expecting

$attribute as item.0.field, and $parameters[0] as item.0.otherfield  
$attribute as item.1.field, and $parameters[0] as item.1.otherfield 

[themsaid]

This is useful for when you need to add a customer validation rule that require passing an implicit rule as a parameter:

Validator::make($data, ['*.username' => 'must_contain:*.id']);

This will allow the validator to convert *.id to (0.id, 1.id, etc..) so when you get the rule parameters you can use the explicit key to get the data of the other branch.

I've reviewed the PR and added some tests, if you'd like I can merge the PR with the changes I made.